Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read in mass, size and type data #93

Merged
merged 11 commits into from
Jan 25, 2022
Merged

Conversation

gomezzz
Copy link
Collaborator

@gomezzz gomezzz commented Jan 18, 2022

Description

Modified our catalog data processing to read in mass, characteristic length and satellite types. This will require some changes to read in the population in the C++ part.

@FG-TUM I would relegate the C++ changes to another PR?

Looks like this now

image

Related Pull Requests

Resolved Issues

How Has This Been Tested?

Created new dataset with it.

@gomezzz gomezzz requested a review from FG-TUM January 18, 2022 15:43
@FG-TUM
Copy link
Collaborator

FG-TUM commented Jan 18, 2022

@FG-TUM I would relegate the C++ changes to another PR?

fine with me. Would it make sense to directly generate HDf5 instead of csv? That way we don't need to support two parsers.

@gomezzz
Copy link
Collaborator Author

gomezzz commented Jan 19, 2022

Would it make sense to directly generate HDf5 instead of csv? That way we don't need to support two parsers.

I think the current CSV parser should be able to handle this file as well with some minor code changes?

I kinda like the CSV because it's humanly readable and at two megabytes this file is not an inconvenience?

Copy link
Collaborator

@FG-TUM FG-TUM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a small header section to all notebooks that describe their

  • purpose
  • input
  • output

Would be easier to keep track of what happens where...

@gomezzz gomezzz mentioned this pull request Jan 25, 2022
14 tasks
@gomezzz gomezzz requested a review from FG-TUM January 25, 2022 11:22
@FG-TUM FG-TUM merged commit 65346c5 into main Jan 25, 2022
@FG-TUM FG-TUM deleted the Read-in-mass,-size-and-type-data branch January 25, 2022 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants