Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Tests #119

Merged
merged 3 commits into from
Feb 18, 2022
Merged

Fix Tests #119

merged 3 commits into from
Feb 18, 2022

Conversation

FG-TUM
Copy link
Collaborator

@FG-TUM FG-TUM commented Feb 18, 2022

Description

Since we actually consider object sizes some tests started to fail because objects were too small / far apart.
Some of these fails also seem to have come from confusion about what is given in m or km.
This PR strives to fix this!

Related Pull Requests

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

  • CI

@FG-TUM FG-TUM requested a review from gomezzz February 18, 2022 17:10
@FG-TUM FG-TUM self-assigned this Feb 18, 2022
Copy link
Collaborator

@gomezzz gomezzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codewise fine, but some tests are still failing or is that expected?

@FG-TUM
Copy link
Collaborator Author

FG-TUM commented Feb 18, 2022

Codewise fine, but some tests are still failing or is that expected?

Nope just means one slipped through. Should be fixed now.

@FG-TUM FG-TUM requested a review from gomezzz February 18, 2022 17:33
@FG-TUM FG-TUM merged commit 8ad55f9 into main Feb 18, 2022
@FG-TUM FG-TUM deleted the fixCollisionEstimate branch February 18, 2022 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants