-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Complex Particle Model + Breakups #103
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- enum in Particle class - update all constructor calls
This now points to a branch. Will need update as soon as it is merged.
- BreakupWrapper to wrap all interaction with the external code - new input parameter - new timer to measure time spent in breakups - new test
Co-authored-by: Pablo Gómez <[email protected]>
Update dataset cpp
FG-TUM
force-pushed
the
mergeBranch
branch
3 times, most recently
from
February 14, 2022 19:10
e8cb84a
to
cc1e4bc
Compare
- made name of expected output file a input var - validation script also gives positive feedback - add git-lfs to CI
reactivated validation tests with new reference - made name of expected output file a input var - validation script also gives positive feedback - add git-lfs to CI
gomezzz
requested changes
Feb 15, 2022
6 tasks
gomezzz
approved these changes
Feb 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
default_cfg.yaml
Related Pull Requests
Combines:
Resolved Issues
All the issues resolved in the PRs above
How Has This Been Tested?