Merge pull request #99 from daniele-pini/fail_on_error_false_level_fix

Fix --level reviewdog option when fail_on_error is false
errata-ai · Sep 25, 2023 · 7542b61 · 7542b61
2 parents 13d7966 + 79437a5
commit 7542b61
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/lib/main.js b/lib/main.js
@@ -60,7 +60,7 @@ function run(actionInput) {
                     `-reporter=${core.getInput('reporter')}`,
                     `-fail-on-error=${should_fail}`,
                     `-filter-mode=${core.getInput('filter_mode')}`,
-                    `-level=${vale_code == 1 && should_fail ? 'error' : 'info'}`
+                    `-level=${vale_code == 1 && should_fail === 'true' ? 'error' : 'info'}`
                 ], {
                     cwd,
                     input: Buffer.from(output.stdout, 'utf-8'),

diff --git a/src/main.ts b/src/main.ts
@@ -46,7 +46,9 @@ export async function run(actionInput: input.Input): Promise<void> {
             `-reporter=${core.getInput('reporter')}`,
             `-fail-on-error=${should_fail}`,
             `-filter-mode=${core.getInput('filter_mode')}`,
-            `-level=${vale_code == 1 && should_fail ? 'error' : 'info'}`
+            `-level=${
+              vale_code == 1 && should_fail === 'true' ? 'error' : 'info'
+            }`
           ],
           {
             cwd,