Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CI OTP versions #2826

Merged
merged 4 commits into from
Sep 17, 2023
Merged

Fix CI OTP versions #2826

merged 4 commits into from
Sep 17, 2023

Conversation

paulo-ferraz-oliveira
Copy link
Contributor

Found while working on #2825.

I was going to do this on that one's scope, but maybe separating it is more proper, especially for review purposes.

In my rebar3 fork this is failing for OTP 25...

@paulo-ferraz-oliveira
Prefer GitHub actions' syntax to shell's
141a7d5 
It also helps to see clearer, in CI, what steps are being skipped

We "fix" the env.var to have it directly related to the matrix one
@paulo-ferraz-oliveira
Increase chances of running tests on the latest 25
77fdbb9 
Because this is controlled by the Erlang/OTP Docker maintainers
25.0 is from Sep 13 2022
25 is from Aug 18 2023
ferd
ferd approved these changes Aug 26, 2023
View reviewed changes
Copy link
Collaborator

@ferd ferd left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

who knows what's broken about brew installs at this time.
Wanted to work on it or just the base versions is all you were aiming for right now? I'm good with the non-macos stuff being fixed for now.

@paulo-ferraz-oliveira
Copy link
Contributor Author

We can leave this open here for a while longer. I code on macOS, too, so it's possible I can figure something out (?) Thanks.

@paulo-ferraz-oliveira
Copy link
Contributor Author

I don't actually know how brew is fed in terms of Erlang/OTP maintenance, but I really hoped this one (erlang/otp#5723) got some attention, as it'd probably eventually benefit setup-beam, too.

@paulo-ferraz-oliveira
Ease pre-pull request CI in forks
6fa30d2 
Otherwise instead of just pushing you have to
create a pull request in the fork too
@paulo-ferraz-oliveira
Fix macOS CI workflow issues
8cd3e25 
This:
- cleans deeper
- updates and upgrades before doctor
- installs the env.-exposed specific latest OTP version
@paulo-ferraz-oliveira
Copy link
Contributor Author

77fdbb9: should be working, for now, but I'm no Homebrew expert (in my rebar3 fork, this shows ✅ in CI), so don't know how long this solution will hold 😄

I also sneaked in a minor change in 6fa30d2, to ease pre-pull request CI (the commit message explains it).

@paulo-ferraz-oliveira paulo-ferraz-oliveira mentioned this pull request Sep 15, 2023
Closed
ferd
ferd approved these changes Sep 17, 2023
View reviewed changes
Copy link
Collaborator

@ferd ferd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be fine for the PR and branch stuff given we don't use any special creds for this and I imagine it being fine to run anywhere for this specific workflow.

@ferd ferd merged commit bbcf3da into erlang:main Sep 17, 2023
6 checks passed
@paulo-ferraz-oliveira paulo-ferraz-oliveira deleted the fix/ci-otp-versions branch September 17, 2023 09:36
@paulo-ferraz-oliveira paulo-ferraz-oliveira mentioned this pull request Sep 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ferd ferd ferd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paulo-ferraz-oliveira @ferd