Test unusual rebar3 corner case where release will fail #2539
Conversation
Test a unusual rebar3 corner case where an Elixir package, built with mix plugin, is released. If done directly, without previous build, the release will fail. Repeat the release, or compile/test before the first release, and the release is successful. First build rebar3 escript used by this test suite. rebar3 escriptize
|
Thanks. I'll consider this as a bug report with a reproducible case more than an actual test suite. I'm not too sure where the final test should belong for this when we figure out a fix since our own test suites avoid depending on the behaviour of third-party plugins or requiring a whole different programming language, but it should help figure out issues and fixes. |
|
Thank you. I tried, and failed, to create a real test case (without plugin, etc). |
This is a bandaid, covering that this one time vsn is a binary, instead of a list. One real solution would be to find out why vsn is binary, and change it there.
|
The work around makes both mixplugin tests pass on my laptop. |
|
Were you on the latest master branch? There was already a fix in the line for some binary-looking versions I believe. |
|
Yes, the master of 17:th April, as far as I know. |
|
Please let me know when reabr3, the escript, will be updated with these ''binary-looking versions''. I can get it then and test. |
|
It should already have them as of yesterday's release. |
|
Greetings,
Sorry, but I got rebar3 (wget https://s3.amazonaws.com/rebar3/rebar3 &&
chmod +x rebar3) today (Tue Apr 20 08:08:59 CES 2021) and the test suite
fail with it.
Well, the first test case fails. The second is not expected to fail. It
only there to test that the first is doing the right thing.
Best Wishes,
bengt
…On Mon, 19 Apr 2021 at 23:01, Fred Hebert ***@***.***> wrote:
It should already have them as of yesterday's release.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#2539 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJBOQU74Z5PZOWNJ3PXZ3DTJSK3LANCNFSM43DD457A>
.
--
Bengt Kleberg
--
Senior Software Engineer
t: +49 391 819099-0
------------------------------- enabling your networks
-----------------------------
Travelping GmbH
Roentgenstraße 13
39108 Magdeburg
Germany
t: +49 391 819099-0
f: +49 391 819099-299
e: ***@***.***
w: https://www.travelping.com/
Company registration: Amtsgericht Stendal
Managing Director: Holger Winkelmann
Reg. No.: HRB 10578
VAT ID: DE236673780
|
Test a unusual rebar3 corner case where an Elixir package, built with mix plugin, is released.
If done directly, without previous build, the release will fail.
Repeat the release, or compile/test before the first release, and the release is successful.
First build rebar3 escript used by this test suite.
rebar3 escriptize
Then run the test
rebar3 ct --suite mixplugin_SUITE