Replace silly variable names that may show up in tooling #8771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uses same variable names in the code as in the spec to avoid confusion.
CT Test ResultsTests are running... https://github.com/erlang/otp/actions/runs/10663608067 Results for commit cb508ea To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts
// Erlang/OTP Github Action Bot |
|
Thanks! Better consistency in naming is always welcome! Would be great if tools used the same algorithm used for extract signatures for EEP-48 doc chunks as described here, or for code that is compiliable it could just extract the signature from the doc chunk and take the names from there. |
|
Filed WhatsApp/erlang-language-platform#53 on the ELP front. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
E.g. when using ELP, these names show up as hints in calls to binary:replace().
Use same variable names in the code as in the spec instead to avoid confusion.