Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ssl: Polish doc #8722

Merged
merged 1 commit into from
Aug 15, 2024
Merged

ssl: Polish doc #8722

merged 1 commit into from
Aug 15, 2024

Conversation

IngelaAndin
Copy link
Contributor

No description provided.

@IngelaAndin IngelaAndin self-assigned this Aug 14, 2024
@IngelaAndin IngelaAndin added the team:PS Assigned to OTP team PS label Aug 14, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 14, 2024 •
edited
Loading

CT Test Results

    2 files     67 suites   48m 13s ⏱️
  791 tests   747 ✅  44 💤 0 ❌
3 760 runs  2 966 ✅ 794 💤 0 ❌

Results for commit b4918ed.

♻️ This comment has been updated with latest results.

To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass.

See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally.

Artifacts

// Erlang/OTP Github Action Bot

RaimoNiskanen
RaimoNiskanen reviewed Aug 14, 2024
View reviewed changes
lib/ssl/doc/ssl_app.md Outdated

The SSL application uses the `public_key`, `asn1` and Crypto application to
The SSL application uses the `public_key`, `asn1` and `Crypto` application to
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have internal guidelines for how to write application names:
http://otp.ericsson.se/internal/guidelines/documentation_guidelines/part_frame.html
http://otp.ericsson.se/product/internal/documentation/conventions/appl_names.shtml
And by that I guess it should be "the Public_Key, Asn1 and Crypto application"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

RaimoNiskanen
RaimoNiskanen approved these changes Aug 14, 2024
View reviewed changes
Copy link
Contributor

@RaimoNiskanen RaimoNiskanen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many whitespace changes, and I don't really know much about how the options should be used, but OK...

@IngelaAndin
Copy link
Contributor Author

The whitespaces changes are removing incorrect formatting of erlang code. If you have dark mode the incorrect formatting will be highlighted. So I took the code and formatted it correctly with the erlang mode and put it back.

@IngelaAndin IngelaAndin force-pushed the ingela/ssl/polish-doc branch 2 times, most recently from 5ba1313 to 47c3abc Compare August 14, 2024 14:50
@IngelaAndin IngelaAndin added the testing currently being tested, tag is used by OTP internal CI label Aug 14, 2024
@IngelaAndin IngelaAndin merged commit 2ca075d into erlang:maint Aug 15, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RaimoNiskanen RaimoNiskanen RaimoNiskanen approved these changes

Assignees

@IngelaAndin IngelaAndin

Labels
team:PS Assigned to OTP team PS testing currently being tested, tag is used by OTP internal CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@IngelaAndin @RaimoNiskanen