Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ssl: Enhance error message #8714

Merged
merged 1 commit into from
Aug 14, 2024
Merged

ssl: Enhance error message #8714

merged 1 commit into from
Aug 14, 2024

Conversation

IngelaAndin
Copy link
Contributor

No description provided.

@IngelaAndin IngelaAndin self-assigned this Aug 13, 2024
@IngelaAndin IngelaAndin requested a review from dgud August 13, 2024 06:56
@IngelaAndin IngelaAndin added team:PS Assigned to OTP team PS testing currently being tested, tag is used by OTP internal CI labels Aug 13, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 13, 2024 •
edited
Loading

CT Test Results

    2 files     67 suites   48m 26s ⏱️
  791 tests   747 ✅  44 💤 0 ❌
3 760 runs  2 966 ✅ 794 💤 0 ❌

Results for commit 31c1a7f.

♻️ This comment has been updated with latest results.

To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass.

See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally.

Artifacts

// Erlang/OTP Github Action Bot

@IngelaAndin IngelaAndin force-pushed the ingela/ssl/enhanch_SNI_host_name_error/OTP-19187 branch from 8a2398e to 31c1a7f Compare August 13, 2024 07:13
dgud
dgud approved these changes Aug 13, 2024
View reviewed changes
Copy link
Contributor

@dgud dgud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests?

@IngelaAndin
Copy link
Contributor Author

The code is covered by the existing test, however we do not normally match on the description part.

@Sinc63
Copy link

Sinc63 commented Aug 13, 2024

Thanks for this improvement. I look forward to debugging my next instance of this after upgrading.

I expect my next request might be to enhance the output for Unknown_CA.

@IngelaAndin
Copy link
Contributor Author

@Sinc63 that might be trickery to implement and give good information about as it means we where not able to verify or recreate a verifiable certificate chain that ends with a certificate that we trust.

@IngelaAndin IngelaAndin merged commit 43cefea into erlang:maint Aug 14, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgud dgud dgud approved these changes

Assignees

@IngelaAndin IngelaAndin

Labels
team:PS Assigned to OTP team PS testing currently being tested, tag is used by OTP internal CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@IngelaAndin @Sinc63 @dgud