Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error handling #8705

Merged

Conversation

dgud
Copy link
Contributor

@dgud dgud commented Aug 9, 2024

Could return undefined if no files where present.

Fixes #8604

@dgud dgud self-assigned this Aug 9, 2024
@dgud dgud added testing currently being tested, tag is used by OTP internal CI team:PS Assigned to OTP team PS labels Aug 9, 2024
Copy link
Contributor

github-actions bot commented Aug 9, 2024

CT Test Results

  2 files   17 suites   5m 26s ⏱️
284 tests 282 ✅ 2 💤 0 ❌
300 runs  298 ✅ 2 💤 0 ❌

Results for commit f2599b4.

♻️ This comment has been updated with latest results.

To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass.

See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally.

Artifacts

// Erlang/OTP Github Action Bot

@dgud dgud requested a review from IngelaAndin August 13, 2024 07:19
@dgud dgud removed the testing currently being tested, tag is used by OTP internal CI label Aug 13, 2024
@IngelaAndin
Copy link
Contributor

I guess you need to care about #8703 too!

Could return undefined if no files where present.
@dgud dgud force-pushed the dgud/public_key/fix-error-reason/GH-8604/OTP-19183 branch from 5e70b43 to f2599b4 Compare August 15, 2024 07:11
@dgud dgud added the testing currently being tested, tag is used by OTP internal CI label Aug 15, 2024
@dgud dgud merged commit 096c279 into erlang:maint Aug 16, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team:PS Assigned to OTP team PS testing currently being tested, tag is used by OTP internal CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants