compiler tests: Correct bad timetrap limit #8680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The compiler's random_code test suite always fails when running with a debug emulator due to a `timeout_value` exit. A `timeout_value` exit appears to be triggered when a timer is given a timeout that is either miss-formed or out of range. Checking the relevant part of `random_code_SUITE`, it appears that the timeout is calculated in milliseconds, but it is given to `ct:timetrap/1` as a timeout in seconds. Although not sure about the exact failure mechanism, changing the calculation to produce a timeout in seconds, allows the test-suite to successfully complete both with an `opt` and `debug` build of the emulator.
CT Test Results 2 files 321 suites 11m 24s ⏱️ Results for commit 9a6084d. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
jhogberg
added
the
testing
|
Merged, thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The compiler's random_code test suite always fails when running with a debug emulator due to a
timeout_valueexit. Atimeout_valueexit appears to be triggered when a timer is given a timeout that is either miss-formed or out of range. Checking the relevant part ofrandom_code_SUITE, it appears that the timeout is calculated in milliseconds, but it is given toct:timetrap/1as a timeout in seconds.Although not sure about the exact failure mechanism, changing the calculation to produce a timeout in seconds, allows the test-suite to successfully complete both with an
optanddebugbuild of the emulator.