erts: Refactor the export table, and optimize fun table inserts #8674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CT Test Results 4 files 152 suites 51m 20s ⏱️ For more details on these failures, see this check. Results for commit e53d572. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
By breaking out the staging-related parts into a separate header, we can use the same mechanism for other things like funs in the near future.
jhogberg
force-pushed
the
john/erts/versioned-fun-tables
branch
3 times, most recently
from
b6a0b16
to
3357657
Compare
jhogberg
added
the
testing
jhogberg
force-pushed
the
john/erts/versioned-fun-tables
branch
from
3357657
to
e53d572
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by #8664, this takes the idea a bit further by avoiding locks altogether when there's already an active fun entry for closures coming through the external term format. It does this by versioning the fun table in the same manner as the export table, sharing the same implementation for both.
This required making fun entries live forever (like export entries), which might kill the PR if there's enough disagreement over that. However, as doing this reclaims at least one word per local fun term I conjecture that it will lead to lower memory usage in practice, given the relative rarity of code purging vs fun creation in most applications.