Ingela/ssl/default cert sign/gh 8588/otp 19152 #8624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IngelaAndin
added
team:PS
CT Test Results 2 files 67 suites 48m 49s ⏱️ Results for commit 5ed2088. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
u3s
reviewed
Jun 28, 2024
IngelaAndin
force-pushed
the
ingela/ssl/default-cert-sign/GH-8588/OTP-19152
branch
from
eb6551e to
8959de3
Compare
u3s
approved these changes
Jul 8, 2024
IngelaAndin
force-pushed
the
ingela/ssl/default-cert-sign/GH-8588/OTP-19152
branch
from
8959de3 to
5ed2088
Compare
Make upgrade path smoother by adding rsa_pkcs1_sha to the default of signature_algs as the default signature_algs_cert. Note this is only applicable when signature_algs is not configured, that is set to the default, that will then become the default of signature_algs_cert in practice. This will allow certificates to use rsa_pkcs1_sha algorithm but still disallow it in the TLS protocol. Also add some missing handling of signature_algs_cert in DTLS. closes erlang#8588
IngelaAndin
force-pushed
the
ingela/ssl/default-cert-sign/GH-8588/OTP-19152
branch
from
5ed2088 to
e57bfe6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Smoother upgrade path, allow certs to still use sha1 but not protocol signatures.