Fix unsafe code generation for binary matching #8622
Merged
+37
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The common sub expression (CSE) optimization could cause a call to a guard BIF to be inserted into the middle of a sequence of binary syntax matching instructions, which in turn could cause unsafe `bs_match` (BEAM) instructions to be emitted. Resolves erlang#8617
CT Test Results 2 files 324 suites 10m 57s ⏱️ Results for commit 60f8f9e. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The common sub expression (CSE) optimization could cause a call to a guard BIF to be inserted into the middle of a sequence of binary syntax matching instructions, which in turn could cause unsafe
bs_match(BEAM) instructions to be emitted.Resolves #8617