Use type information to improve destructive update pass #8621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't include outgoing embedding edges among the aliasing edges as they do not contribute to the alias status of the aggregate in which the node is embedded. This change corrects errors where aggregates were mistakenly classified as aliased, but fortunately with regards to compiler correctness this only leads to missed optimization opportunities.
Make use of type information when tracking initial values during the destructive update pass. Using argument type annotations allows the find-initial-values phase of the pass to stop exploring impossible value chains which previously lead to infinite loops which in turn made the pass abort.
CT Test Results 2 files 324 suites 10m 38s ⏱️ Results for commit 5607e82. ♻️ This comment has been updated with latest results. To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass. See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally. Artifacts// Erlang/OTP Github Action Bot |
bjorng
added
team:VM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a bug in the alias analysis pass which led to missed optimization opportunities and improve the destructive update pass to use types in order to avoid unnecessary aborts. More details in the individual commit messages.