Merge pull request #8728 from bjorng/bjorn/kernel/fix-error-explanation

Fix error information for `code:get_coverage/2`
erlang · Aug 19, 2024 · 5da80a1 · 5da80a1
2 parents 0881e4e + 49288c0
commit 5da80a1
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/lib/kernel/src/erl_kernel_errors.erl b/lib/kernel/src/erl_kernel_errors.erl
@@ -50,7 +50,8 @@ format_code_error(get_coverage, [What,Module]) ->
               Error = case What of
                           function -> [];
                           line -> [];
-                          _ -> <<"must be one of: function or line">>
+                          cover_line_id -> [];
+                          _ -> coverage_level
                       end,
               case Error of
                   [] ->
@@ -367,6 +368,8 @@ expand_error(bad_tracer) ->
     <<"invalid tracer">>;
 expand_error(coverage_disabled) ->
     <<"not loaded with coverage enabled">>;
+expand_error(coverage_level) ->
+    <<"must be one of: function, line, or cover_line_id">>;
 expand_error(eq_in_list) ->
     <<"\"=\" characters is not allowed in environment variable names">>;
 expand_error(zero_in_list) ->

diff --git a/lib/kernel/test/code_coverage_SUITE.erl b/lib/kernel/test/code_coverage_SUITE.erl
@@ -270,6 +270,7 @@ error_info(_Config) ->
          {get_coverage, [line,42]},
          {get_coverage, [line,NotLoaded]},
          {get_coverage, [line,?MODULE]},
+         {get_coverage, [cover_line_id,NotLoaded]},
          {get_coverage, [whatever,?MODULE]},
 
          {reset_coverage, [42]},