Merge branch 'ingela/ssl/tls-1.3-gracefullness/OTP-17848' into maint

* ingela/ssl/tls-1.3-gracefullness/OTP-17848: ssl: Enhanche errorhandling, always shutdown gracefully
erlang · Aug 11, 2024 · 4c4105b · 4c4105b
2 parents 67c3249 + c2a7878
commit 4c4105b
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/lib/ssl/src/tls_server_connection_1_3.erl b/lib/ssl/src/tls_server_connection_1_3.erl
@@ -505,7 +505,10 @@ do_handle_client_hello(#client_hello{cipher_suites = ClientCiphers,
         end
     catch
         {Ref, #alert{} = Alert} ->
-            Alert
+            Alert;
+        error:Reason:ST ->
+            ?SSL_LOG(debug, handshake_error, [{reason, Reason}, {stacktrace, ST}]),
+            ?ALERT_REC(?ILLEGAL_PARAMETER, illegal_parameter_in_client_hello)
     end.
 
 send_hello_flight({start_handshake, PSK0},
@@ -586,7 +589,8 @@ send_hello_flight({start_handshake, PSK0},
     catch
         {Ref, #alert{} = Alert} ->
             Alert;
-        error:badarg ->
+        error:Reason:ST ->
+            ?SSL_LOG(debug, crypto_error, [{reason, Reason}, {stacktrace, ST}]),
             ?ALERT_REC(?ILLEGAL_PARAMETER, illegal_parameter_to_compute_key)
     end.