Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate rebar.lock and few other improvements. #4

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

gleber
Copy link
Member

@gleber gleber commented Mar 7, 2016

Generating rebar.lock allows to bypass a lot of magical logic in rebar3.

Other improvements described in commit descriptions. Corresponding PR in nixpkgs will follow, but this code will work even without it.

gleber added 2 commits March 7, 2016 08:50
This removes build variability. Also fix adding of "pc" to the plugins
list. And some code deduplication.
This depends on nixpkgs to:

- populate ERLANG_DEPS enviromental variable with list of all erlang
  dependencies of a given packag
- create $out/nix-support/appName file containing application
  name (which can be different from nix package name) for each Erlang
  package.
@ericbmerritt
Copy link
Contributor

I am a bit worried about rewriting the rebar.config in place. This works for things we are building, but doesn't really work for development. I wonder if we can't generate a rebar.config.script that does the rewriting on the fly. Or perhaps, its a flag wether we update the rebar.config in place or generate a script.

@gleber
Copy link
Member Author

gleber commented Mar 7, 2016

This part is not new. I believe it was there before.

I've seen some projects which use rebar.config.script on their own, so this
would still be a bit problematic. I think the only way around it is to
either move ask the logic into Nix or provide alternative mode of operation
for development workflow. I wonder if rebar takes an argument which could
point it to a new rewritten configuration file.
On Mar 7, 2016 3:54 PM, "Eric Merritt" [email protected] wrote:

I am a bit worried about rewriting the rebar.config in place. This works
for things we are building, but doesn't really work for development. I
wonder if we can't generate a rebar.config.script that does the rewriting
on the fly. Or perhaps, its a flag wether we update the rebar.config in
place or generate a script.


Reply to this email directly or view it on GitHub
#4 (comment)
.

@ericbmerritt
Copy link
Contributor

It looks like we can have a different config by setting the REBAR_CONFIG env variable. That is probably the way to go here.

@ericbmerritt
Copy link
Contributor

@gleber thoughts?

@gleber
Copy link
Member Author

gleber commented Mar 11, 2016

This is a good idea and it looks like the way to go here. I just didn't
have time to try this out yet.
On Mar 11, 2016 00:54, "Eric Merritt" [email protected] wrote:

@gleber https://github.com/gleber thoughts?


Reply to this email directly or view it on GitHub
#4 (comment)
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants