Fix the jumping of focus back to the TabList whenever one of the Movi…

…e action buttons is clicked
erin-doyle · Sep 2, 2018 · a855e2e · a855e2e
1 parent a78d9cf
commit a855e2e
Showing 1 changed file with 8 additions and 2 deletions.
diff --git a/src/primitives/TabList.js b/src/primitives/TabList.js
@@ -31,8 +31,14 @@ class TabList extends Component {
         this.focusTabList();
     }
 
-    componentDidUpdate() {
-        this.focusTabList();
+    componentDidUpdate(prevProps) {
+        const { match } = this.props;
+
+        // Only when the selected tab has changed do we need to focus that TabList
+        // NOTE: this prevents extra focus jumping when other things change (i.e. Movie watched status)
+        if (prevProps.match.url !== match.url) {
+            this.focusTabList();
+        }
     }
 
     setTabListRef(element) {