feat: allow changing transition duration #140
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows developers to specify the transition duration like so:
Status
Ready for review
Description
Adds an optional argument to
NesVerticalCloseTransition.route
(and likewise with the other transition classes) to specify the transition duration, see adil192/ricochlime#41.My first thought was to add a field to
NesOverlayTransitionTheme
but since the durations are different for each transition (i.e. 750ms vs 1750ms), it would be less verbose to just add a parameter to the....route<T>()
functions.Type of Change