Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add sound icon variation #123

Merged
merged 5 commits into from
Jan 29, 2024
Merged

feat: Add sound icon variation #123

merged 5 commits into from
Jan 29, 2024

Conversation

chrisstayte
Copy link
Contributor

@chrisstayte chrisstayte commented Jan 29, 2024 •
edited
Loading

Status

READY

Description

Added a variation to the audio icon called audioMuted. This is a replication of the audio symbol with a slash through it.

Screenshot 2024-01-29 at 11 39 53 AM

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore
  • 🧪 Tests

erickzanardo
erickzanardo reviewed Jan 29, 2024
View reviewed changes
Copy link
Owner

@erickzanardo erickzanardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can you just add an entry for this new icon in the changelog.

I believe this is not a section yet for the next version, so you can just bootstrap a new one as 0.15.0

@erickzanardo erickzanardo changed the title Add sound icon variation feat: Add sound icon variation Jan 29, 2024
@chrisstayte
Copy link
Contributor Author

Added the icon to the change log @erickzanardo

@erickzanardo erickzanardo merged commit 009f091 into erickzanardo:main Jan 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erickzanardo erickzanardo erickzanardo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chrisstayte @erickzanardo