fix: nes dialog has configurable generics now (#75)

erickzanardo · Sep 7, 2023 · 05d377e · 05d377e
1 parent 1f7cfcf
commit 05d377e
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 4 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,6 @@
 # 0.9.0
  - feat: add `NesIcons.expand`
+ - fix: `NesDialog` allows a generic to be informed.
 
 # 0.8.0
  - feat: add `NesIcons.leftHand`

diff --git a/example/lib/gallery/sections/dialogs.dart b/example/lib/gallery/sections/dialogs.dart
@@ -21,7 +21,7 @@ class DialogsSection extends StatelessWidget {
               type: NesButtonType.normal,
               child: const Text('Plain'),
               onPressed: () {
-                NesDialog.show(
+                NesDialog.show<void>(
                   context: context,
                   builder: (_) => const Text('Hello World'),
                 );

diff --git a/lib/src/widgets/dialogs/nes_dialog.dart b/lib/src/widgets/dialogs/nes_dialog.dart
@@ -17,11 +17,11 @@ class NesDialog extends StatelessWidget {
   final Widget child;
 
   /// A shortcut method that can be used to show this dialog.
-  static Future<bool?> show({
+  static Future<T?> show<T>({
     required BuildContext context,
     required WidgetBuilder builder,
   }) {
-    return showGeneralDialog<bool>(
+    return showGeneralDialog<T>(
       context: context,
       transitionBuilder: (context, animation, secondaryAnimation, child) {
         return Transform.scale(

diff --git a/test/src/widgets/dialogs/nes_dialog_test.dart b/test/src/widgets/dialogs/nes_dialog_test.dart
@@ -14,7 +14,7 @@ extension NesDialogTest on WidgetTester {
             return NesButton(
               type: NesButtonType.normal,
               onPressed: () async {
-                final value = await NesDialog.show(
+                final value = await NesDialog.show<bool>(
                   context: context,
                   builder: (_) => const Text('Hello World'),
                 );