Fix invalid aria values (#438)

ericgio · Apr 25, 2019 · f83e178 · f83e178
1 parent d9aab6d
commit f83e178
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/src/__tests__/components/Typeahead.test.js b/src/__tests__/components/Typeahead.test.js
@@ -904,7 +904,7 @@ describe('<Typeahead>', () => {
 
   describe('accessibility attributes', () => {
     test('adds an id to the menu for accessibility', () => {
-      expect(getInput(typeahead).prop('aria-owns')).toBe('');
+      expect(getInput(typeahead).prop('aria-owns')).toBe(undefined);
 
       focus(typeahead);
 
@@ -950,7 +950,7 @@ describe('<Typeahead>', () => {
 
     test('sets the input `aria-activedescendant` description', () => {
       typeahead.setProps({ id: 'my-id' });
-      expect(getInput(typeahead).prop('aria-activedescendant')).toBe('');
+      expect(getInput(typeahead).prop('aria-activedescendant')).toBe(undefined);
 
       focus(typeahead);
       keyDown(typeahead, DOWN);

diff --git a/src/__tests__/utils/getInputProps.test.js b/src/__tests__/utils/getInputProps.test.js
@@ -17,11 +17,11 @@ const baseMultiProps = {
 };
 
 const baseReceivedProps = {
-  'aria-activedescendant': '',
+  'aria-activedescendant': undefined,
   'aria-autocomplete': 'both',
   'aria-expanded': false,
   'aria-haspopup': 'listbox',
-  'aria-owns': '',
+  'aria-owns': undefined,
   autoComplete: 'off',
   className: '',
   onClick: undefined,

diff --git a/src/utils/getInputProps.js b/src/utils/getInputProps.js
@@ -30,11 +30,11 @@ const getInputProps = ({
     ...rest,
     'aria-activedescendant': activeIndex >= 0 ?
       getMenuItemId(id, activeIndex) :
-      '',
+      undefined,
     'aria-autocomplete': 'both',
     'aria-expanded': isMenuShown,
     'aria-haspopup': 'listbox',
-    'aria-owns': isMenuShown ? id : '',
+    'aria-owns': isMenuShown ? id : undefined,
     className: cx({
       [className || '']: !multiple,
       focus: isFocused,