Fix MenuItem typing

ericgio · Jul 6, 2022 · 53689b6 · 53689b6
1 parent c6c62de
commit 53689b6
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 6 deletions.
diff --git a/src/components/MenuItem/BaseMenuItem.stories.tsx b/src/components/MenuItem/BaseMenuItem.stories.tsx
@@ -10,10 +10,7 @@ export default {
   component: BaseMenuItem,
 } as Meta;
 
-const Template: Story<BaseMenuItemProps> = (args) => (
-  // @ts-ignore
-  <BaseMenuItem {...args} />
-);
+const Template: Story<BaseMenuItemProps> = (args) => <BaseMenuItem {...args} />;
 
 export const Default = Template.bind({});
 Default.args = {

diff --git a/src/components/MenuItem/MenuItem.tsx b/src/components/MenuItem/MenuItem.tsx
@@ -1,11 +1,12 @@
 import cx from 'classnames';
-import React, { forwardRef, HTMLProps, MouseEvent } from 'react';
+import React, { forwardRef, HTMLAttributes, MouseEvent } from 'react';
 
 import { useItem, UseItemProps } from '../../behaviors/item';
 
-export interface BaseMenuItemProps extends HTMLProps<HTMLAnchorElement> {
+export interface BaseMenuItemProps extends HTMLAttributes<HTMLAnchorElement> {
   active?: boolean;
   disabled?: boolean;
+  href?: string;
 }
 
 export const BaseMenuItem = forwardRef<HTMLAnchorElement, BaseMenuItemProps>(