Use role="button" instead of href in MenuItem (#97)

* bugfix: dont use a href * PR 97 review: use role=button * PR 97 review: alphabetize props for linter
ericgio · Oct 24, 2016 · 399f5aa · 399f5aa
1 parent 13edccb
commit 399f5aa
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/src/MenuItem.react.js b/src/MenuItem.react.js
@@ -33,7 +33,7 @@ const MenuItem = React.createClass({
           'active': active,
           'disabled': disabled,
         }, className)}>
-        <a href="#" onClick={this._handleClick}>
+        <a onClick={this._handleClick} role="button">
           {children}
         </a>
       </li>