Resolve helper script issues on Windows starting wtih Node.js v20.12.2 #1515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to observed test failures for Windows on v20.12.2
This fixes an issue with this project's helper scripts that started in Node.js v20.12.2 due to the fix for CVE-2024-27980. In particular, we spawn using `npm.cmd` on Windows to be able to run npm scripts programmatically (just `npm` doesn't work on Windows), however because of the CVE this is no longer allowed without setting `shell: true`. In this context, setting `shell: true` doesn't really matter (all input is considered trusted) so we just do that.
ericcornelissen
changed the title
ericcornelissen
added
meta
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #1513, #1514, and
Summary
Started due to observed test failures for Windows on v20.12.2. The resolution for CVE-2024-27980 causes the project's script helper function for spawning new npm commands to fail. This is a just a simple fix to bypass that fix.