Improve breakage tests #1262
Merged
Improve breakage tests #1262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add tests verifying that the `Shescape` and `Stubscape` constructors by themselves behave the same way between the development head and last released version. This should improve confidence as without these tests there is a chance that the implementation is changed such that, e.g., on the development head the constructor throws where in the last version all methods would throw instead (which is a breaking change). By having a test dedicated to the constructor, the described scenario would be caught. Also some reformatting because I didn't like the way the tests were written before.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #1233
Summary
Add breakage tests verifying that the
ShescapeandStubscapeconstructors by themselves behave the same way between the development head and last released version.This should improve confidence as without these tests there is a chance that the implementation is changed such that, e.g., on the development head the constructor throws where in the last version all methods would throw instead (which is a breaking change). By having a test dedicated to the constructor, the described scenario would be caught.