Expand stubs available in testing module #1149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
Codecov Report
@@ Coverage Diff @@
## main #1149 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 16 16
Lines 1449 1465 +16
=========================================
+ Hits 1449 1465 +16
Flags with carried forward coverage won't be shown. Click here to find out more.
|
ericcornelissen
force-pushed
the
expand-testing-module
branch
from
987c8f5 to
e84d4c6
Compare
ericcornelissen
commented
Sep 21, 2023
- Correct the test title for the unit test of `Throwscape`. - Use property testing for the functional integration test of `Throwscape`. - Use a differential property test for the CJS version of `Throwscape`. - Correct file overview of integration tests for the testing module: there's now multiple testing implementations. - Update functional integration test titles to make clear what testing implementation's API function is being tested.
Update the Stubscape implementation so that the behavior of `quote` and `quoteAll` is more similar to the real implementation of Shescape. Tests are updated accordingly, mostly resulting in cleaner integration tests (with more coverage) at the minor cost of more specific unit tests (that actually more accurately reflect expected behavior). Also update the Stubscape JSDoc to be up-to-date, both with respect to the changes seen here as well as the changes of v3.0.0.
This was referenced Nov 19, 2023
This was referenced Apr 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merges into #963
Summary
Provide additional stubs to users from the testing module now that Shescape has additional failure modes.