Provide a v1-like stateless API in v2 #1130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericcornelissen
force-pushed
the
oneshot-module
branch
from
2fec11c to
d700861
Compare
ericcornelissen
changed the title
Currently entirely skipped because there's no previous version to test against.
This was referenced Dec 17, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1130 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 16 17 +1
Lines 1507 1627 +120
==========================================
+ Hits 1507 1627 +120
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This was referenced Dec 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #963
Summary
Add a new importable module that offers an interface akin to the v1 interface for use cases where initializing a class (to reduce duplicate work) doesn't make sense, e.g. when only a single value needs to be escaped per execution.