Skip to content

Commit

Permalink
Remove the dependency on knip (#1823)
Browse files Browse the repository at this point in the history
Remove knip as it adds little value to this project as a continuous
check, instead it might still be used occasionally to review the
dependencies of this project. Along with the removal of the dependency
its configuration file is also removed. This removes the only jsonc file
from the project, which is reflected in other checks too.
  • Loading branch information
ericcornelissen authored Dec 19, 2024
1 parent a4e3d80 commit 248fe8f
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 239 deletions.
16 changes: 0 additions & 16 deletions config/eslint.js
Original file line number Diff line number Diff line change
Expand Up @@ -1021,22 +1021,6 @@ export default [
"json/top-level-interop": ["error"],
},
},
{
name: "JSONC",
files: ["config/**/*.jsonc"],
plugins: { json },
language: "json/jsonc",
languageOptions: {
allowTrailingCommas: true,
},
rules: {
// https://github.com/eslint/json/blob/main/README.md#rules
"json/no-duplicate-keys": ["error"],
"json/no-empty-keys": ["error"],
"json/no-unnormalized-keys": ["error"],
"json/no-unsafe-values": ["error"],
},
},
{
name: "YAML",
files: [".github/**/*.yml", "config/**/*.yml", ".lockfile-lintrc.yml"],
Expand Down
12 changes: 0 additions & 12 deletions config/knip.jsonc

This file was deleted.

211 changes: 3 additions & 208 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 2 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,6 @@
"fast-check": "3.22.0",
"husky": "9.1.1",
"is-ci": "4.1.0",
"knip": "5.37.2",
"licensee": "11.1.1",
"lockfile-lint": "4.13.1",
"ls-engines": "0.9.3",
Expand All @@ -106,10 +105,10 @@
"audit:vulnerabilities:runtime": "better-npm-audit audit --production",
"check": "npm-run-all check:*",
"check:ci": "node script/maybe-run.js actionlint",
"check:dependencies": "knip --config config/knip.jsonc && node script/check-runtime-deps.js",
"check:dependencies": "node script/check-runtime-deps.js",
"check:formatting": "npm run _prettier -- --check",
"check:js": "npm run _eslint -- '**/*.{cjs,js}'",
"check:json": "npm run _eslint -- '**/*.{json,jsonc}'",
"check:json": "npm run _eslint -- '**/*.json'",
"check:licenses": "licensee --errors-only",
"check:lockfile": "lockfile-lint",
"check:manifest": "npm run transpile && publint --strict && attw --pack . && ls-engines",
Expand Down

0 comments on commit 248fe8f

Please sign in to comment.