Skip to content

Commit

Permalink
Update breakage tests to run against v2.0.1 (#1269)
Browse files Browse the repository at this point in the history
Update the breakage tests to run against v2.0.1. This keeps the breakage
tests up-to-date and allows for unskipping all tests that either fixed
bugs observable by the breakage tests or were for previously unreleased
APIs.
  • Loading branch information
ericcornelissen authored Oct 28, 2023
1 parent 3e4c4d6 commit 094541d
Show file tree
Hide file tree
Showing 4 changed files with 13 additions and 15 deletions.
1 change: 1 addition & 0 deletions .github/labeler.yml
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ meta:
- .shellcheckrc

test:
- test/breakage/**
- test/compat/**
- test/e2e/**
- test/fixtures/**
Expand Down
8 changes: 4 additions & 4 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@
"prettier": "3.0.3",
"publint": "0.2.4",
"rollup": "4.1.4",
"shescape-previous": "npm:[email protected].0",
"shescape-previous": "npm:[email protected].1",
"sinon": "17.0.0"
},
"scripts": {
Expand Down
17 changes: 7 additions & 10 deletions test/breakage/testing.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,10 @@ import * as fc from "fast-check";
import { arbitrary } from "./_.js";

import { Shescape as Stubscape, Throwscape } from "shescape/testing";
import { Shescape as Previoustub } from "shescape-previous/testing";
import {
Shescape as Previoustub,
Throwscape as Previousthrow,
} from "shescape-previous/testing";

testProp(
"Stubscape#constructor",
Expand Down Expand Up @@ -91,9 +94,7 @@ testProp(
},
);

// TODO: unskip upon release 2.0.1/2.1.0. It's currently skipped because the
// implementation was incorrect in 2.0.0 and has been fixed since (in 4f03fd8).
testProp.skip(
testProp(
"Stubscape#quote",
[arbitrary.shescapeOptions(), fc.anything()],
(t, options, arg) => {
Expand All @@ -120,9 +121,7 @@ testProp.skip(
},
);

// TODO: unskip upon release 2.0.1/2.1.0. It's currently skipped because the
// implementation was incorrect in 2.0.0 and has been fixed since (in 4f03fd8).
testProp.skip(
testProp(
"Stubscape#quoteAll",
[
arbitrary.shescapeOptions(),
Expand Down Expand Up @@ -152,9 +151,7 @@ testProp.skip(
},
);

// TODO: unskip upon release 2.0.1/2.1.0. It's currently skipped because the
// `Throwscape` class was not yet release in 2.0.0 (added in 4f03fd8).
testProp.skip(
testProp(
"Throwscape#constructor",
[arbitrary.shescapeOptions()],
(t, options) => {
Expand Down

0 comments on commit 094541d

Please sign in to comment.