Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecation warning about registry plugin #15

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

alechirsch
Copy link
Contributor

This removes the deprecation notice:

Registry plugin was moved into core Bookshelf. You can now register models using `bookshelf.model()` and collections using `bookshelf.collection()` without having to call `.plugin('registry')`. Remove any `.plugin('registry')` calls to clear this message.

It also fixes deprecations for createTableIfNotExists in knex, and findWhere in bookshelf.

I tried to run the tests with upgraded bookshelf and knex versions, however one of the tests failed and I spent way too much time trying to figure out what was causing it.

@alechirsch
Copy link
Contributor Author

@blah238 Would you be able to get this through?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant