Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Todo cleanup #125

Merged
merged 1 commit into from
Jun 5, 2024
Merged

Todo cleanup #125

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion include/events.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,6 @@ void print_map(const std::map<unsigned int, std::vector<unsigned int>> & map);

extern const Stock_event STOCK_SPLIT_EVENT;

/// @todo Understand this constexpr lambda
inline const unsigned int sumOfAllEventsProbability = []() {
unsigned int sum = 0;
for (const auto & event : all_stock_events) {
Expand Down
4 changes: 1 addition & 3 deletions src/stock.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,9 +64,7 @@ void Stock::load(const std::string & playerName, int i) {
// get the first line, which is category
fin >> *this; // use operator>> to load the Stock object
fin.close();
// @todo Do not hardcode this limit, use a constant
// STOCK_PRICE_LIMIT instead
assert(price <= 1000 && "Price exceed the limit");
assert(price <= STOCK_PRICE_LIMIT && "Price exceed the limit");
std::cout << "done" << std::endl;
}

Expand Down
Loading