Refactor Stock::save() load() into operator>> and fix bug #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric15342335
added
bug
Add one assertion and removed one magic number
From Makefile: make fix
…ever appear The event duration was reduced by durationDecreaseMultipler right after the stock split event was added. Fix: Rearrange the order
From Makefile: make fix
eric15342335
changed the title
Stock operator>> operator<< and Fix hsi.save printvector() bugStock::save() load(), fix hsi.save printvector() and stock split event bug
From Makefile: make fix
From Makefile: make fix
eric15342335
force-pushed
the
stock-io-operator
branch
from
6e8d7bd to
58fe86a
Compare
|
didn't mean this PR has bug tho |
|
The get_hsi() bug might not present in v1? |
Signed-off-by: Cheng Ho Ming, Eric <[email protected]>
eric15342335
changed the title
Stock::save() load(), fix hsi.save printvector() and stock split event bug
eric15342335
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
printvector()bug was introduced in this commit, specifically:comp2113-engg1340-group-project/src/file_io.cpp
Lines 230 to 236 in 172764c