fix: Dict::get

erg-lang · Sep 21, 2024 · 9887d78 · 9887d78
1 parent f6145d0
commit 9887d78
Show file tree

Hide file tree

Showing 5 changed files with 23 additions and 10 deletions.
diff --git a/crates/erg_compiler/context/initialize/classes.rs b/crates/erg_compiler/context/initialize/classes.rs
@@ -2359,14 +2359,13 @@ impl Context {
         )));
         dict_.register_builtin_const(FUNC_AS_RECORD, Visibility::BUILTIN_PUBLIC, None, as_record);
         let Def = type_q(TY_DEFAULT);
+        let K = type_q(TY_K);
+        let V = type_q(TY_V);
         let get_t = no_var_fn_met(
-            dict_t.clone(),
-            vec![kw(KW_KEY, T.clone())],
+            dict! { K.clone() => V.clone() }.into(),
+            vec![kw(KW_KEY, K.clone())],
             vec![kw_default(KW_DEFAULT, Def.clone(), NoneType)],
-            or(
-                proj_call(D.clone(), FUNDAMENTAL_GETITEM, vec![ty_tp(T.clone())]),
-                Def,
-            ),
+            or(V.clone(), Def),
         )
         .quantify();
         dict_.register_py_builtin(FUNC_GET, get_t, Some(FUNC_GET), 9);

diff --git a/crates/erg_compiler/context/initialize/funcs.rs b/crates/erg_compiler/context/initialize/funcs.rs
@@ -1077,8 +1077,9 @@ impl Context {
         );
         let E = mono_q(TY_E, subtypeof(mono(EQ)));
         let E2 = mono_q(TY_E, subtypeof(mono(IRREGULAR_EQ)));
-        let op_t = bin_op(E.clone(), E, Bool).quantify()
-            & bin_op(E2.clone(), E2.clone(), E2.proj(OUTPUT)).quantify();
+        let op_t = (bin_op(E.clone(), E, Bool).quantify()
+            & bin_op(E2.clone(), E2.clone(), E2.proj(OUTPUT)).quantify())
+        .with_default_intersec_index(0);
         self.register_builtin_py_impl(
             OP_EQ,
             op_t.clone(),

diff --git a/crates/erg_compiler/lower.rs b/crates/erg_compiler/lower.rs
@@ -1221,7 +1221,17 @@ impl<A: ASTBuildable> GenericASTLowerer<A> {
                 Some(guard(namespace, target, to))
             }
             TokenKind::Symbol if &op.content[..] == "isinstance" => {
-                let to = self.module.context.expr_to_type(rhs.clone()).ok()?;
+                // isinstance(x, (T, U)) => x: T or U
+                let to = if let ast::Expr::Tuple(ast::Tuple::Normal(tys)) = rhs {
+                    tys.elems.pos_args.iter().fold(Type::Never, |acc, ex| {
+                        let Ok(ty) = self.module.context.expr_to_type(ex.expr.clone()) else {
+                            return acc;
+                        };
+                        self.module.context.union(&acc, &ty)
+                    })
+                } else {
+                    self.module.context.expr_to_type(rhs.clone()).ok()?
+                };
                 Some(guard(namespace, target, to))
             }
             TokenKind::IsOp | TokenKind::DblEq => {

diff --git a/tests/should_err/mut_dict.er b/tests/should_err/mut_dict.er
@@ -4,4 +4,6 @@ dict = !d
 dict.insert! "b", 2
 _ = dict.get("a") == "a" # ERR
 _ = dict.get("b") == "a" # ERR
-_ = dict.get("c") # ERR
+_ = dict.get("c") # OK
+_ = dict["b"] # OK
+_ = dict["c"] # ERR
diff --git a/tests/should_ok/dict.er b/tests/should_ok/dict.er
@@ -6,5 +6,6 @@ for! {"a": 1, "b": 2}.values(), i =>
 dic = { "a": 1, "b": 2 }
 assert dic.concat({ "c": 3 }) == { "a": 1, "b": 2, "c": 3 }
 assert dic.diff({ "a": 1 }) == { "b": 2 }
+assert dic.get("a"+"b", 3) == 3
 rec = dic.as_record()
 assert rec.a == 1 and rec.b == 2