-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RRTMGP Port #2062
RRTMGP Port #2062
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pressel can you take a look at the following:
ERF/Source/Radiation/ERF_Radiation.cpp
Line 425 in e531a88
// TODO: Fill properly |
ERF/Source/Radiation/ERF_Radiation.cpp
Line 449 in e531a88
// TODO: Fill properly |
ERF/Source/Radiation/ERF_Radiation.cpp
Line 455 in e531a88
// TODO: Fill properly |
ERF/Source/Radiation/ERF_Radiation.cpp
Line 595 in e531a88
tmp2d(icol,ilay) = qv_lay(icol,ilay) * mwdair/ gas_mol_weight; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lwp
and iwp
are filled in a specific spot. I did away with nc_lay
since it was only used for output data we don't have or use. I think the h2o vmr is computed correctly, but a second set of eyes would be useful.
The eff_radius
quantities are inputs that we must compute; any insight there would be helpful.
This adds radiation via
RRTMGP
andYAKL
. TheRRTMGP
submodule is set to coincide with what is currently used by the EAMXX component of E3SM; see here. The files added to ERF are modeled after and ported from those used in EAMXX; see here.TODO action items:
mu0, albedo, zenith
)lat/lon
availability (only with real init?)