Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge updates for NOAH-MP Interface #1994

Merged
merged 34 commits into from
Dec 17, 2024

Conversation

akashdhruv
Copy link
Contributor

@akashdhruv akashdhruv commented Dec 3, 2024

In this PR I have formalized the NoahMP C++ interface so it can be used by other codes. I have embedded the logic of AMReX_TableData.H structures directly within the Noah-MP library using a header file NoahArray.H.

Client C++ applications like ERF will have to manage an object of NoahmpIO_type similar to Fortran applications. NoahmpIO_type contains bounds and pointers to Fortran data casted as multidimensional arrays in C++. The data structures are interdependent, so physics units can directly modify and access data that will be used/modified on Fortran side.

The initialization works as follows

NoahmpIO_type noahmpio;
NoahmpIOVarInit(&noahmpio);
NoamphInitMain(&noahmpio);

Note that noampio is private member of the NOAH class that inherits from NullSurf class. I have added C++ specific documentation to sphinx and the full NoahMP documentation can be found here (https://opensky.ucar.edu/islandora/object/technotes:599)

@akashdhruv akashdhruv marked this pull request as draft December 3, 2024 16:39
@akashdhruv akashdhruv marked this pull request as ready for review December 17, 2024 18:34
@AMLattanzi AMLattanzi merged commit d7ebfae into erf-model:development Dec 17, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants