Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: populate terrain arrays before initializing microphysics object #1749

Closed
wants to merge 1 commit into from

Conversation

debog
Copy link
Contributor

@debog debog commented Aug 20, 2024

Terrain arrays must be populated before the microphysics object is initialized because they are used by the micro->Init() function.

@debog
Copy link
Contributor Author

debog commented Aug 20, 2024

@AMLattanzi @asalmgren Is this fix correct?

@asalmgren
Copy link
Collaborator

Hey @debog -- I'm actually in the middle of doing some additional fixes -- by definition if it works it's correct :-) I'll merge this then incorporate it in the changes I'm doing now, which needed fixing when we are doing regridding with terrain ...

@debog
Copy link
Contributor Author

debog commented Aug 20, 2024

Hey @debog -- I'm actually in the middle of doing some additional fixes -- by definition if it works it's correct :-) I'll merge this then incorporate it in the changes I'm doing now, which needed fixing when we are doing regridding with terrain ...

Sure! It works for one test that we are trying (it fixed initializing our particle-based microphysics model with terrain). I hope it did not break something else that depended on that particular order of initialization.

@asalmgren
Copy link
Collaborator

@debog - would you mind if I actually close this PR and submit my PR with this changes and a number of others?

@debog
Copy link
Contributor Author

debog commented Aug 20, 2024

This fix will be addressed by @asalmgren's PR.

@debog debog closed this Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants