Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regtests with Real BCs and correct a bug #1693

Merged
merged 1 commit into from
Jul 18, 2024
Merged

Fix regtests with Real BCs and correct a bug #1693

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Source/BoundaryConditions/ERF_FillPatch.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@ ERF::FillPatch (int lev, Real time,
#ifdef ERF_USE_NETCDF
// We call this here because it is an ERF routine
if (use_real_bcs && (lev==0)) {
fill_from_realbdy(mfs_vel,time,false,0,ncomp_cons);
fill_from_realbdy(mfs_vel,time,false,icomp_cons,ncomp_cons);
}
#endif

Expand Down Expand Up @@ -398,7 +398,7 @@ ERF::FillIntermediatePatch (int lev, Real time,
#ifdef ERF_USE_NETCDF
// We call this here because it is an ERF routine
if (use_real_bcs && (lev==0)) {
fill_from_realbdy(mfs_vel,time,false,0,ncomp_cons);
fill_from_realbdy(mfs_vel,time,false,icomp_cons,ncomp_cons);
}
#endif

Expand Down
4 changes: 2 additions & 2 deletions Source/TimeIntegration/TI_fast_rhs_fun.H
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,10 +172,10 @@ auto fast_rhs_fun = [&](int fast_step, int /*n_sub*/, int nrk,
// box over which VelocityToMomentum is computed. V2M requires one more ghost cell be
// filled for rho than velocity. This logical condition ensures we fill enough ghost cells
// when use_NumDiff is true.
int ng_cons = S_data[IntVars::cons].nGrowVect().max();
int ng_cons = S_data[IntVars::cons].nGrowVect().max() - 1;
int ng_vel = S_data[IntVars::xmom].nGrowVect().max();
if (!solverChoice.use_NumDiff) {
ng_cons = 2;
ng_cons = 1;
ng_vel = 1;
}
apply_bcs(S_data, new_substep_time, ng_cons, ng_vel, fast_only=true, vel_and_mom_synced=false);
Expand Down
Loading