Check for compile warnings in CI #1685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed several compiler warnings have crept into the code. This PR adds a check in ci.yml that will cause a failure if there are any compiler warnings, and fixes several warnings such that that check passes.
Similar code should be added to other workflows, but holding off until confirming this is something we want. The check is lifted directly from PeleC, so it was probably in ERF but taken out at some point. I do think requiring that PRs don't introduce warnings is a good thing and helps keep the code clean for both users and developers, but IDK if this is the best way and open to discussion on the topic.