-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Brunt-Vaisala freq into Smag model #1625
Conversation
This has stability issues with the MOST boundary condition. It is very easy for the |
To avoid the stability issue with MOST, I have added Finally, some non-negligible errors were found with the MOST boundary condition. I reformulated it to compute the covariance term directly (e.g. |
This PR brings in the Brunt-Vaisala scaling for the Smagorinsky model. It includes dry and moist computations of the
fb
scaling parameter.NOTE: This will likely modify all the Smagorinsky regtests and the vertical gradients are not aware of the boundary conditions at z_hi or z_lo.
See the follwowing sources:
Sec 2.7.2 (14) - (15)
Approximation in (36)