Nudging Index Fix #1387
Merged
Nudging Index Fix #1387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ii/jj variables ensure that we do not go out of bounds when accessing the bdy data for nudging. The variable width that is passed into wrfbdy_compute_interior_ghost_rh is 1 less than the total width of the bdy data; this is because the last element of the bdy data is ghost cell for the Laplacian operator. However, when interpolating data into the FArrayBoxes we will need to access that ghost cell value; it is needed for the velocity to momentum conversion. Previously, the +/- 1 prevented ii/jj from getting to the last element of the bdy data. Since the FLOWMAS project is heavily using this functionality, I have left the debug statements in Utils.H. Once we have confidence everything is good, this should be deleted.