chore: rename validation associated hooks to module entity associated hooks #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary by OctaneNew ContractsNo new contracts were added in this PR. Updated Contracts
🔗 Commit Hash: dd3fe66 |
This comment was marked as resolved.
This comment was marked as resolved.
howydev
force-pushed
the
howy/rename-exechook-association
branch
from
95e9102 to
dd3fe66
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The term "validation associated hooks" could potentially be confusing as it sounds like the hooks are run whenever a specific validation function are run. However, the hooks are actually associated to an entity, referenced by a (validation module + entity id) pair
I suggest we improve the framing to be around "entity associated hooks" as that's more accurate. This PR changes the variable names and comments to use "module entity associated hooks"