Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update constant name for MAX_PRE_VALIDATION_HOOKS #201

Merged

Conversation

jaypaik
Copy link
Collaborator

@jaypaik jaypaik commented Oct 15, 2024

Motivation

Solution

Copy link

Summary by Octane

New Contracts

No new contracts were added in this PR.

Updated Contracts

  • ModuleManagerInternals.sol: The primary change updates the constant name from MAX_PRE_VALIDATION_HOOKS to MAX_VALIDATION_ASSOC_HOOKS.
  • Constants.sol: Updated to allow more types of validation-associated hooks to be registered.

🔗 Commit Hash: 8bf2511

@jaypaik jaypaik requested a review from adamegyed October 15, 2024 20:02
@jaypaik jaypaik merged commit 8135729 into develop Oct 15, 2024
4 checks passed
@jaypaik jaypaik deleted the 10-15-fix_update_constant_name_for_MAX_PRE_VALIDATION_HOOKS branch October 15, 2024 20:03
Copy link

Overview

Vulnerabilities found: 2                                                                                
Severity breakdown: 1 Critical, 1 Medium

Detailed findings

src/account/AccountFactory.sol


🔗 Commit Hash: 8bf2511
🛡️ Octane Dashboard: All vulnerabilities

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants