Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: SparseCalldataSegmentLib optimization #200

Merged
merged 1 commit into from
Oct 15, 2024
Merged

feat: SparseCalldataSegmentLib optimization #200

merged 1 commit into from
Oct 15, 2024

Conversation

jaypaik
Copy link
Collaborator

@jaypaik jaypaik commented Oct 15, 2024

Returning calldata instead of memory.

@octane-security-app Octane Security App
Copy link

Summary by Octane

New Contracts

  • EmptyCalldataSlice.sol: The smart contract provides a function to return an empty bytes calldata slice using inline assembly.

Updated Contracts

  • SparseCalldataSegmentLib.sol: The smart contract now returns a dedicated empty calldata slice instead of an empty string for non-matching segments.

🔗 Commit Hash: 3bb7980

@jaypaik jaypaik requested a review from a team October 15, 2024 18:27
@octane-security-app Octane Security App
Copy link

Overview

Octane AI analysis has finished. No vulnerabilities were found. Cheers! 🎉🎉🎉

🔗 Commit Hash: 3bb7980

@jaypaik jaypaik merged commit 2e8ca59 into develop Oct 15, 2024
4 checks passed
@jaypaik jaypaik deleted the 10-15-feat_SparseCalldataSegmentLib_optimization branch October 15, 2024 18:33
jaypaik added a commit that referenced this pull request Oct 15, 2024
@jaypaik
feat: SparseCalldataSegmentLib optimization (#200)
f6e4b2b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fangting-alchemy fangting-alchemy fangting-alchemy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jaypaik @fangting-alchemy