Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Web Platform Issues #7

Merged
merged 16 commits into from
Jan 8, 2025
Merged

Conversation

erayzesen
Copy link
Owner

The current GDExtension file was created based on a version of Godot prior to 4.3, meaning it predates the introduction of the multithreads option for the web platform, and it is actually flawed (it throws errors due to incorrect file links). However, starting with Godot version 4.3, threads can now be enabled/disabled during export for the web platform, addressing a significant need (e.g., SharedArrayBuffer issues).

Therefore, the necessary actions are as follows:

  • The GDExtension file should be updated to align with these changes.
  • A no-thread alternative should be added to the GitHub Actions files for web builds.

As a result of this PR, the plugin package provided to the user should allow exporting to the web platform with all options, as supported by the latest version of Godot.

@erayzesen erayzesen marked this pull request as ready for review January 8, 2025 18:23
@erayzesen erayzesen merged commit 2c01cab into master Jan 8, 2025
48 checks passed
@erayzesen erayzesen deleted the bugfix/fix-web-platform-issues branch January 8, 2025 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant