Add --silent option #201
Merged
Add --silent option #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwiker
reviewed
May 21, 2024
rwiker
approved these changes
May 21, 2024
equinor-ruaj
approved these changes
May 21, 2024
|
Could also replace the three flags ("interactive", "devicecode", "silent") with a single parameter "mode" that takes a parameter ("interactive", "devicecode", "silent") with "interactive" as the default.
… On 22 May 2024, at 11:49, Runar Ask Johannessen ***@***.***> wrote:
@equinor-ruaj commented on this pull request.
In src/sumo/wrapper/login.py <#201 (comment)>:
> @@ -33,7 +34,7 @@ def get_parser() -> ArgumentParser:
"--interactive",
dest="interactive",
action="store_true",
- default=False,
+ default=True,
Seems correct. The current config will always set interactive to True not matter what.
Should either remove default completely or set default=False
—
Reply to this email directly, view it on GitHub <#201 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAIDQOSKJM633WGNUOEKCUTZDRS4BAVCNFSM6AAAAABIBLFKQKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDANZQGY4TMMZUGM>.
You are receiving this because your review was requested.
|
Will give this a try 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Edit: replace --silent, --interactive and --devicecode with a --mode flag