make it possible to influence the retry strategy #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… timeout in sumo-core-nodejs is 60 seconds and we may have multiple replicas.
|
Good point; I’ve added a comment.
… On 13 Nov 2023, at 15:09, Runar Ask Johannessen ***@***.***> wrote:
@equinor-ruaj approved this pull request.
lgtm
In tests/test_sumo_thin_client.py <#172 (comment)>:
> @@ -226,7 +226,7 @@ def test_upload_duplicate_ensemble(token):
result = _delete_object(C=C, object_id=case_id1)
assert result == "Accepted"
- sleep(50)
+ sleep(61)
Should we have a comment here to remember why it is set to 61?
—
Reply to this email directly, view it on GitHub <#172 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAIDQOW6IKNFB4OFUCOIPZLYEISZ7AVCNFSM6AAAAAA7JFKT7WVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTOMRXGM4TMMBYGE>.
You are receiving this because you authored the thread.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, it is possible to pass a
RetryStrategyobject to theSumoClient. This allows us to specify values forstop_after(maximum number of tries),exp_base(the factor by which the retry sleep delay is increased for each retry) andmultiplier(the initial retry sleep delay).