Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refact: use getComponent when getting 1 comp #1187

Merged
merged 4 commits into from
Nov 22, 2024
Merged

Conversation

asmfstatoil
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@EvenSol EvenSol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes support this. Could it be that computational speed is affected?

@codecov-commenter
Copy link

codecov-commenter commented Nov 21, 2024

Codecov Report

Attention: Patch coverage is 35.94616% with 809 lines in your changes missing coverage. Please review.

Project coverage is 39.59%. Comparing base (d3bdf14) to head (1b7b70c).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...c/main/java/neqsim/thermo/system/SystemThermo.java 44.00% 42 Missing ⚠️
...ndary/reactivefilmmodel/ReactiveFluidBoundary.java 0.00% 37 Missing ⚠️
...ops/saturationops/BubblePointPressureFlashDer.java 0.00% 35 Missing ⚠️
.../java/neqsim/thermo/mixingrule/EosMixingRules.java 33.33% 26 Missing and 6 partials ⚠️
...thermodynamicoperations/flashops/TPmultiflash.java 37.25% 30 Missing and 2 partials ⚠️
...ops/saturationops/DewPointTemperatureFlashDer.java 0.00% 32 Missing ⚠️
...qsim/mathlib/nonlinearsolver/SysNewtonRhapson.java 0.00% 26 Missing ⚠️
.../multicomponentenvelopeops/PTphaseEnvelopeMay.java 0.00% 26 Missing ⚠️
...perations/flashops/SysNewtonRhapsonTPflashNew.java 0.00% 23 Missing ⚠️
...ermodynamicoperations/flashops/TPmultiflash_1.java 0.00% 23 Missing ⚠️
... and 73 more
Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1187   +/-   ##
=========================================
  Coverage     39.59%   39.59%           
  Complexity     5869     5869           
=========================================
  Files           717      717           
  Lines         69748    69702   -46     
  Branches       8123     8117    -6     
=========================================
- Hits          27616    27598   -18     
+ Misses        40471    40443   -28     
  Partials       1661     1661           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@asmfstatoil
Copy link
Collaborator Author

Yes support this. Could it be that computational speed is affected?

Not sure if Java JIT optimizer already handles this. But is probably faster when debugging.

@EvenSol
Copy link
Collaborator

EvenSol commented Nov 21, 2024

Yes support this. Could it be that computational speed is affected?

Not sure if Java JIT optimizer already handles this. But is probably faster when debugging.

It seems like the tests are running at the same speed - so propably this is just fine (and with no significant perfomrance change).

I suggest we merge this.

@asmfstatoil asmfstatoil merged commit da485d0 into master Nov 22, 2024
9 checks passed
@asmfstatoil asmfstatoil deleted the ref_getcomponents branch November 22, 2024 11:37
asmfstatoil added a commit that referenced this pull request Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants