Add triggering anonymizer from endpoint #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olaals
force-pushed
the
add-triggering-anonymizer-from-endpoint
branch
from
f36c084
to
9376504
Compare
tsundvoll
requested changes
Nov 19, 2024
api/Services/AnonymizerService.cs
Outdated
| public class AnonymizerService | ||
| { | ||
| private static readonly HttpClient client = new(); | ||
|
|
||
| public async Task TriggerAnonymizerFunc(InspectionData data) | ||
| { | ||
| var json = JsonSerializer.Serialize(data); | ||
| var dto = new TriggerAnonymizerRequest(data.InspectionId, data.RawDataUri, data.AnonymizedUri); |
There was a problem hiding this comment.
What is dto, can we make it a longer, more descriptive name?
| public class TriggerAnonymizerRequest | ||
| { | ||
| public required string InspectionId { get; set; } | ||
| public required string Name { get; set; } |
There was a problem hiding this comment.
What will name describe here? Do we need it?
olaals
force-pushed
the
add-triggering-anonymizer-from-endpoint
branch
from
9376504
to
131b133
Compare
olaals
force-pushed
the
add-triggering-anonymizer-from-endpoint
branch
from
131b133
to
aabb5d1
Compare
|
🔔 Changes in database folder detected 🔔 |
olaals
force-pushed
the
add-triggering-anonymizer-from-endpoint
branch
from
aabb5d1
to
a584089
Compare
tsundvoll
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.